Re: Slightly improve initdb --sync-only option's help message

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Gurjeet Singh <gurjeet(at)singh(dot)im>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Slightly improve initdb --sync-only option's help message
Date: 2021-07-29 09:10:25
Message-ID: 3F4AB299-A440-445F-90D1-6E7BB22F4771@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 26 Jul 2021, at 20:05, Bossart, Nathan <bossartn(at)amazon(dot)com> wrote:

> Here are my suggestions in patch form.

- printf(_(" -S, --sync-only only sync data directory\n"));
+ printf(_(" -S, --sync-only safely write all database files to disk and exit\n"));

I think removing the word "only" here is a net loss, since it IMO clearly
conveyed that this option isn't doing any of the other initdb duties. The
documentation states it in more words, but the help output must be brief so I
think "only" is a good keyword.

--
Daniel Gustafsson https://vmware.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2021-07-29 09:11:13 Re: [PoC] Improve dead tuple storage for lazy vacuum
Previous Message Ronan Dunklau 2021-07-29 09:09:40 Re: pg_receivewal starting position