Re: updated win32 patch

Bruce Momjian wrote:
> Jan, have you committed this change to CVS yet?

No and I don't see any reason to do so. It was code we needed at
PeerDirect for something that was never supposed to be contributed. I
allways warned that one will have a hard time to get changes into the
CVS that are only for support of proprietary stuff and of no benefit for
anyone else.

Jan

>
> ---------------------------------------------------------------------------
>
> Jan Wieck wrote:
>
>>Neil Conway wrote:
>> and AFAICS the following function that the patch
>>
>>>adds isn't related to Win32 at all:
>>>
>>>+ /* For unknown parameter type during parse */
>>>+ void set_param_type(int t, Oid typid)
>>>+ {
>>>+ if ((t > pfunc_num_args) || (t <= 0))
>>>+ return;
>>>+ param_type_info[t - 1] = typid;
>>>+ }
>>
>>Good catch ...
>>
>>That one is part of something that enables SPI preparation of plans with
>>parameters of unknown datatype. The caller of SPI_prepare then will find
>>the datatypes choosen by the parser/planner in the array passed in. Need
>>to make that a separate one ...
>>
>>
>>Jan
>>
>>--
>>#======================================================================#
>># It's easier to get forgiveness for being wrong than for being right. #
>># Let's break this rule - forgive me. #
>>#================================================== JanWieck(at)Yahoo(dot)com #
>>
>>---------------------------(end of broadcast)---------------------------
>>TIP 3: if posting/reading through Usenet, please send an appropriate
>>subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
>>message can get through to the mailing list cleanly
>>
>
>

--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #