Re: [HACKERS] [WIP] Zipfian distribution in pgbench

From: Alik Khilazhev <a(dot)khilazhev(at)postgrespro(dot)ru>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [WIP] Zipfian distribution in pgbench
Date: 2017-11-20 15:16:59
Message-ID: 3EB1383F-4358-4131-8848-65EC7408B138@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers


> Patch applies with "patch", but not with "git apply", probably because it is in CR-NL eol format. No big deal.
>
> Documentation has been switched from SGML to XML, so now tags must be explicitely closed, i.e. use <foo>x</foo> instead of <foo>x</>.
>
> Patch compiles with a warning:
>
> Declaration must move before assertion.
>
> "array overflow on \random_zipfian" remove spurious "\".

Fixed.

> The random_zipfian(1,100,2) call result is not tested.

I have reduced range to [1, 10] and updated the test.

> "1 times" -> "once”.

I am not sure that it need to be fixed in this way, because there can be another number instead of 1.
So, I updated it to “%d time(s)”

Attachment Content-Type Size
pgbench-zipf-10v.patch application/octet-stream 12.9 KB
unknown_filename text/plain 121 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2017-11-20 15:18:30 Re: [HACKERS] Custom compression methods
Previous Message Aleksander Alekseev 2017-11-20 13:48:36 Re: Jsonb transform for pl/python