Re: [HACKERS] [WIP] Zipfian distribution in pgbench

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Alik Khilazhev <a(dot)khilazhev(at)postgrespro(dot)ru>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [WIP] Zipfian distribution in pgbench
Date: 2017-11-20 16:09:11
Message-ID: alpine.DEB.2.20.1711201656320.754@lancre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello Alik,

Patch applies, compiles, works (I checked the distribution). Doc gen ok.
make check ok.

> I have reduced range to [1, 10] and updated the test.

I would suggest to use [1, 9] and the simpler regex [1-9] instead of the
full list.

Also, there should be an empty line between functions. I just noticed that
one is missing after zipfFindOrCreateCacheCell().


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2017-11-20 16:31:45 Re: [HACKERS] Custom compression methods
Previous Message Ildus Kurbangaliev 2017-11-20 15:44:35 Re: [HACKERS] Custom compression methods