Re: quote_ident and schemas (was Re: [HACKERS] connectby with schema)

Tom Lane wrote:
> Since connectby takes a string parameter (correct?) for the table name,
> my advice would be to have it not do quote_ident, but instead expect the
> user to include double quotes in the string value if dealing with
> mixed-case names. Compare the behavior of nextval() for example:
>
> regression=# select nextval('Foo.Bar');
> ERROR: Namespace "foo" does not exist
> regression=# select nextval('"Foo"."Bar"');
> ERROR: Namespace "Foo" does not exist
> regression=# select nextval('"Foo.Bar"');
> ERROR: Relation "Foo.Bar" does not exist
>

OK. Attached patch removes calls within the function to quote_ident, requiring
the user to appropriately quote their own identifiers. I also tweaked the
regression test to deal with "value" becoming a reserved word.

If it's not too late, I'd like this to get into 7.3, but in any case, please
apply to HEAD.

Thanks,

Joe

p.s. There are similar issues in dblink, but they appear a bit more difficult
to address. I'll attempt to get them resloved this weekend, again in hopes to
get them applied before 7.3 is released.