Re: Small patch for pg_basebackup argument parsing

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info>
Cc: Ryan Murphy <ryanfmurphy(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: Small patch for pg_basebackup argument parsing
Date: 2017-09-13 00:06:50
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 05 Jul 2017, at 08:32, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Jul 5, 2017 at 2:57 PM, Ryan Murphy <ryanfmurphy(at)gmail(dot)com> wrote:
>> I tried to apply your patch to test it (though reading Robert's last comment it seems we wish to have it adjusted before committing)... but in any case I was not able to apply your patch to the tip of the master branch (my git apply failed). I'm setting this to Waiting On Author for a new patch, and I also agree with Robert that the test can be simpler and can go in the other order. If you don't have time to make another patch, let me know, I may be able to make one.
> git is unhappy even if forcibly applied with patch -p1. You should
> check for whitespaces at the same time:
> $ git diff --check
> src/bin/pg_basebackup/pg_receivewal.c:483: indent with spaces.
> + char *strtol_endptr = NULL
> And there are more than this one.

Like Michael said above, this patch no longer applies and have some whitespace
issues. The conflicts in applying are quite trivial though, so it should be
easy to create a new version. Do you plan to work on this during this
Commitfest so we can move this patch forward?

cheers ./daniel

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Joseph Krogh 2017-09-13 00:11:25 Re: Clarification in pg10's pgupgrade.html step 10 (upgrading standby servers)
Previous Message Daniel Gustafsson 2017-09-12 23:59:35 Re: Replication status in logical replication