Re: ResultSet.getDate failure with timestamp column

This bug has been fixed.

thanks,
--Barry

PS. I didn't use the diff below since I also noticed that two other
changes were also backed out in 1.29. So this fix fixes all three.

Daniel Germain wrote:

> Hi,
>
> diff -c "c:/postgresql/ResultSet.java.orig" "c:/postgresql/ResultSet.java"
> *** c:/postgresql/ResultSet.java.orig Wed Nov 07 14:37:52 2001
> --- c:/postgresql/ResultSet.java Fri Nov 09 08:46:30 2001
> ***************
> *** 1554,1560 ****
> {
> if (s == null)
> return null;
> ! return java.sql.Date.valueOf(s);
> }
>
> public static Time toTime(String s) throws SQLException
> --- 1554,1566 ----
> {
> if (s == null)
> return null;
> ! // length == 10: SQL Date
> ! // length > 10: SQL Timestamp, assumes PGDATESTYLE=ISO
> ! try {
> ! return java.sql.Date.valueOf((s.length() == 10) ? s :
> s.substring(0,10));
> ! } catch (NumberFormatException e) {
> ! throw new PSQLException("postgresql.res.baddate", s);
> ! }
> }
>
> public static Time toTime(String s) throws SQLException
>
> Diff finished at Fri Nov 09 08:47:03
>
> Daniel
>
>
>>-----Original Message-----
>>From: Barry Lind [mailto:barry(at)xythos(dot)com]
>>Sent: November 8, 2001 10:50 PM
>>To: Daniel Germain
>>Cc: pgsql-jdbc(at)postgresql(dot)org
>>Subject: Re: ResultSet.getDate failure with timestamp column
>>
>>
>>Daniel,
>>
>>You are correct. Version 1.29 backed out the previous fix. I will fix
>>this when I get a chance (unless you want to submit a patch and save me
>>some time?).
>>
>>thanks,
>>--Barry
>>
>>Daniel Germain wrote:
>>
>>
>>>Hi,
>>>
>>>I'm trying to migrate an existing application to postgresql
>>>that uses generated code for accessing the database layer.
>>>
>>>I search the mailing list and found other references to that problem
>>>which seems to have been fixed in Revision 1.26 of ResultSet.java
>>>and seems to be removed in Revision 1.29
>>>
>>>Here is the stack trace with the DevelopmentDriver 7.2dev
>>>
>>(built 2001-10-31)
>>
>>>java.lang.NumberFormatException: 04 00:00:00-04
>>> at java.lang.Integer.parseInt(Integer.java:414)
>>> at java.lang.Integer.parseInt(Integer.java:454)
>>> at java.sql.Date.valueOf(Date.java:91)
>>> at org.postgresql.jdbc2.ResultSet.toDate(ResultSet.java:1557)
>>> at org.postgresql.jdbc2.ResultSet.getDate(ResultSet.java:372)
>>> at org.postgresql.jdbc2.ResultSet.getDate(ResultSet.java:607)
>>>
>>>
>>>Any good reason why it was removed? It seems to be contrary to the
>>>spec from what I read in this mailing list.
>>>
>>>Thanks
>>>
>>>Daniel
>>>
>>>
>>>
>>>---------------------------(end of broadcast)---------------------------
>>>TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org
>>>
>>>
>>>
>>
>
>