Importing pg_bsd_indent into our source tree

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Importing pg_bsd_indent into our source tree
Date: 2023-02-09 18:30:30
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

As per the discussion at [1], here's a patchset to integrate
pg_bsd_indent into our main source tree, so that people don't
have to pull down a separate repo to get this tool.

0001 is a verbatim import of the current pg_bsd_indent repo contents.
I felt committing this separately is useful for traceability.

0002 adjusts the copyright notices to 3-clause BSD style,
so that we don't get complaints about our tree containing
copyrights inconsistent with the main Postgres license.

0003 is the first non-boring bit: it updates the Makefile
and some other things to account for now being an in-tree
build not out-of-tree. Also, since 0002 already meant that
the README isn't exactly like upstream's, I got rid of the
separate README.pg_bsd_indent file and merged that info
into README.

0004 is the patch discussed at [2] to improve pgindent's
handling of multiline variable initializations.

0003 lacks meson support (anyone want to help with that?)
but otherwise these seem committable to me. I'd anticipate
pushing 0001-0003 shortly but holding 0004 until we are ready
to do the post-March-CF pgindent run. (Come to think of it,
0004 had probably better include a pg_bsd_indent version
bump too.)

regards, tom lane


Attachment Content-Type Size
v1-0001-import-pg_bsd_indent-verbatim.patch text/x-diff 179.0 KB
v1-0002-adjust-pg_bsd_indent-copyright.patch text/x-diff 9.7 KB
v1-0003-merge-into-our-build-system.patch text/x-diff 7.3 KB
v1-0004-fix-initialization-indenting.patch text/x-diff 1.5 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2023-02-09 18:34:34 Re: run pgindent on a regular basis / scripted manner
Previous Message Andres Freund 2023-02-09 18:16:45 Re: MacOS: xsltproc fails with "warning: failed to load external entity"