Re: [PATCH] Support negative indexes in split_part

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jacob Champion <pchampion(at)pivotal(dot)io>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Nikhil Benesch <nikhil(dot)benesch(at)gmail(dot)com>
Subject: Re: [PATCH] Support negative indexes in split_part
Date: 2020-11-13 18:53:27
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Jacob Champion <pchampion(at)pivotal(dot)io> writes:
> Patch looks good to me. Seems like a useful feature, and I agree that the two-pass implementation makes the change very easy to review.

LGTM too. I made a couple of cosmetic improvements and pushed it.

> Quick note on test coverage: gcov marks the "needle not found" branch (the one marked `/* special case if fldsep not found at all */`) as being completely uncovered. I don't think that needs to gate this patch; it looks like it was uncovered before this feature was added.

We seem to be trying for full test coverage of this function now,
so I added a test case for that branch too.

> Doc builds are currently failing due to what appears to be an xmllint failure:

Unrelated, but see

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2020-11-13 19:07:38 Re: Zedstore - compressed in-core columnar storage
Previous Message Justin Pryzby 2020-11-13 18:11:21 Re: error_severity of brin work item