Re: [PATCH] Support negative indexes in split_part

From: Jacob Champion <pchampion(at)pivotal(dot)io>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Nikhil Benesch <nikhil(dot)benesch(at)gmail(dot)com>
Subject: Re: [PATCH] Support negative indexes in split_part
Date: 2020-11-10 19:38:16
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested

Patch looks good to me. Seems like a useful feature, and I agree that the two-pass implementation makes the change very easy to review.

Quick note on test coverage: gcov marks the "needle not found" branch (the one marked `/* special case if fldsep not found at all */`) as being completely uncovered. I don't think that needs to gate this patch; it looks like it was uncovered before this feature was added.

Doc builds are currently failing due to what appears to be an xmllint failure:

/usr/bin/xmllint --path . --noout --valid postgres.sgml
error : Unknown IO error
postgres.sgml:21: warning: failed to load external entity ""

but that doesn't have anything to do with this patch. Marking Ready for Committer. (I'm a little new to this myself, so someone please let me know if I'm jumping the gun.)


The new status of this patch is: Ready for Committer

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2020-11-10 20:09:04 Re: proposal: possibility to read dumped table's name from file
Previous Message Tom Lane 2020-11-10 19:30:08 Re: Strange behavior with polygon and NaN