Re: refactoring basebackup.c

From: tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
To: Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: refactoring basebackup.c
Date: 2022-01-03 17:12:03
Message-ID: 38e18142-9fd7-0d05-501c-451081060407@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/22/21 11:05 PM, Jeevan Ladhe wrote:
> Please find the lz4 compression patch here that basically has:
Please refer to this  scenario , where --server-compression is only
compressing
base backup into lz4 format but not pg_wal directory

[edb(at)centos7tushar bin]$ ./pg_basebackup -Ft --server-compression=lz4
-Xstream -D foo

[edb(at)centos7tushar bin]$ ls foo
backup_manifest  base.tar.lz4  pg_wal.tar

this same is valid for gzip as well if server-compression is set to gzip

edb(at)centos7tushar bin]$ ./pg_basebackup -Ft --server-compression=gzip4
-Xstream -D foo1

[edb(at)centos7tushar bin]$ ls foo1
backup_manifest  base.tar.gz  pg_wal.tar

if this scenario is valid then both the folders format should be in lz4
format otherwise we should
get an error something like - not a valid option ?

--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2022-01-03 17:24:19 Re: Proposal: sslmode=tls-only
Previous Message Justin Pryzby 2022-01-03 16:50:12 Re: [PATCH] pg_stat_toast v0.4