Re: [PATCH] Improve geometric types

On 09/23/2018 11:55 PM, Tomas Vondra wrote:
> On 09/03/2018 04:08 AM, Tom Lane wrote:
>> Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
>>> On 08/17/2018 11:23 PM, Tom Lane wrote:
>>>> Yeah, we've definitely hit such problems before. The geometric logic
>>>> seems particularly prone to it because it's doing more and subtler
>>>> float arithmetic than the rest of the system ... but it's not the sole
>>>> source of minus-zero issues.
>>
>>> We can go through the patch and fix places with obvious -0 risks, but
>>> then what? I don't have access to any powepc machines, so I can't check
>>> if there are any other failures. So the only thing I could do is commit
>>> and fix based on buildfarm failures ...
>>
>> That's the usual solution. I don't see anything particularly wrong
>> with it. If the buildfarm results suggest a whole mess of problems,
>> it might be appropriate to revert and rethink; but you shouldn't be
>> afraid to use the buildfarm as a testbed.
>>
>
> FWIW I plan to get this committed sometime this week, when I'm available
> to fix the expected buildfarm breakage.
>

Pushed. Now let's wait for the buildfarm to complain ...

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services