Re: MERGE lacks ruleutils.c decompiling support!?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: MERGE lacks ruleutils.c decompiling support!?
Date: 2023-05-05 21:06:34
Message-ID: 3787884.1683320794@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Here's a first attempt. I mostly just copied code from the insert and
> update support routines. There's a couple of things missing still, but
> I'm not sure I'll get to it tonight. I only tested to the extent of
> what's in the new regression test.

I did a bit of review and more work on this:

* Added the missing OVERRIDING support

* Played around with the pretty-printing indentation

* Improved test coverage, and moved the test to rules.sql where
I thought it fit more naturally.

I think we could probably commit this, though I've not tried it
in v15 yet.

regards, tom lane

Attachment Content-Type Size
0001-add-ruleutils.c-support-for-MERGE-v2.patch text/x-diff 8.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Cary Huang 2023-05-05 22:30:21 Re: [PATCH] Allow Postgres to pick an unused port to listen
Previous Message Andres Freund 2023-05-05 20:34:31 Re: benchmark results comparing versions 15.2 and 16