Re: [PATCH] Logical decoding of TRUNCATE

From: Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Logical decoding of TRUNCATE
Date: 2018-01-25 13:21:15
Message-ID: 372b6f96-8415-912a-de72-ec5f54ad677f@2ndquadrant.it
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-general pgsql-hackers

Il 25/01/18 13:18, Petr Jelinek ha scritto:
> On 25/01/18 08:26, Thomas Munro wrote:
>> On Wed, Jan 24, 2018 at 6:47 AM, Marco Nenciarini
>> <marco(dot)nenciarini(at)2ndquadrant(dot)it> wrote:
>>> Version 16 attached.
>>
>> Hi Marco,
>>
>> FYI this version doesn't compile:
>>
>> worker.c: In function ‘apply_handle_truncate’:
>> worker.c:888:39: error: ‘cascade’ undeclared (first use in this function)
>> relid = logicalrep_read_truncate(s, &cascade, &restart_seqs);
>> ^
>>
>

Fixed.

> Indeed.
>
> We also found one more issue - the truncate done by logical replication
> worker is not logically logged which would break cascading.
>

Fixed.

> I expect Marco to send new version shortly with both of these fixed.
>
New patch v17 attached.

Regards,
Marco

--
Marco Nenciarini - 2ndQuadrant Italy
PostgreSQL Training, Services and Support
marco(dot)nenciarini(at)2ndQuadrant(dot)it | www.2ndQuadrant.it

Attachment Content-Type Size
0001-truncate_ignore_fks_role_replica.v4.patch text/plain 2.8 KB
0002-logical_decode_truncate.v17.patch text/plain 54.4 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Laurenz Albe 2018-01-25 16:51:56 Re: PGSQL 10, many Random named DB
Previous Message Petr Jelinek 2018-01-25 12:18:34 Re: [PATCH] Logical decoding of TRUNCATE

Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Freire 2018-01-25 13:56:08 Re: [HACKERS] Vacuum: allow usage of more than 1GB of work mem
Previous Message Alexander Korotkov 2018-01-25 13:10:26 Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index