Re: [HACKERS] Vacuum: allow usage of more than 1GB of work mem

From: Claudio Freire <klaussfreire(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Andres Freund <andres(at)anarazel(dot)de>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com>, PostgreSQL-Dev <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Vacuum: allow usage of more than 1GB of work mem
Date: 2018-01-25 13:56:08
Message-ID: CAGTBQpZkEmcY6BudoBKfR1=UfTK4yDA3B0YxRFyP=cQnwwzwRg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 25, 2018 at 4:11 AM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> On Thu, Jan 18, 2018 at 9:17 AM, Claudio Freire <klaussfreire(at)gmail(dot)com> wrote:
>> Huh. That was simpler than I thought.
>>
>> Attached rebased versions.
>
> Hi Claudio,
>
> FYI the regression test seems to have some run-to-run variation.
> Though it usually succeeds, recently I have seen a couple of failures
> like this:
>
> ========= Contents of ./src/test/regress/regression.diffs
> *** /home/travis/build/postgresql-cfbot/postgresql/src/test/regress/expected/vacuum.out
> 2018-01-24 01:41:28.200454371 +0000
> --- /home/travis/build/postgresql-cfbot/postgresql/src/test/regress/results/vacuum.out
> 2018-01-24 01:51:07.970049937 +0000
> ***************
> *** 128,134 ****
> SELECT pg_relation_size('vactst', 'main');
> pg_relation_size
> ------------------
> ! 0
> (1 row)
>
> SELECT count(*) FROM vactst;
> --- 128,134 ----
> SELECT pg_relation_size('vactst', 'main');
> pg_relation_size
> ------------------
> ! 8192
> (1 row)
>
> SELECT count(*) FROM vactst;
> ======================================================================
>
> --
> Thomas Munro
> http://www.enterprisedb.com

I'll look into it

However, shouldn't an empty relation have an initial page anyway? In
that case shouldn't the correct value be 8192?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2018-01-25 13:59:52 Re: [HACKERS] GSoC 2017: weekly progress reports (week 4) and patch for hash index
Previous Message Marco Nenciarini 2018-01-25 13:21:15 Re: [PATCH] Logical decoding of TRUNCATE