| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication - detail message with names of missing columns |
| Date: | 2020-09-11 14:10:32 |
| Message-ID: | 370580.1599833432@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> writes:
>> I think we always double-quote identifiers in error messages. For
>> example:
>> ./catalog/heap.c 706: errmsg("no collation was derived for column \"%s\"
>> with collatable type %s",
Right. Anything in this patch that is not doing that needs to be fixed.
(As this example shows, type names are exempt from the rule.)
> How about quoting all the individual columns? Looks like quote_identifier()
> doesn't serve our purpose here as it selectively quotes or quotes all
> identifiers only in case quote_all_identifiers config variable is set.
NO. The convention is to write \"...\" in the translatable message.
Not all languages use double quote symbols for this purpose, so that
way lets translators replace them with something else.
Yeah, this means that messages containing names that contain double
quotes might be a bit ambiguous. We live with it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-09-11 14:35:46 | Re: Logical Replication - detail message with names of missing columns |
| Previous Message | John Naylor | 2020-09-11 14:08:15 | Re: WIP: BRIN multi-range indexes |