From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Logical Replication - detail message with names of missing columns |
Date: | 2020-09-11 14:35:46 |
Message-ID: | 20200911143546.GA23894@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020-Sep-11, Tom Lane wrote:
> > How about quoting all the individual columns? Looks like quote_identifier()
> > doesn't serve our purpose here as it selectively quotes or quotes all
> > identifiers only in case quote_all_identifiers config variable is set.
>
> NO. The convention is to write \"...\" in the translatable message.
> Not all languages use double quote symbols for this purpose, so that
> way lets translators replace them with something else.
>
> Yeah, this means that messages containing names that contain double
> quotes might be a bit ambiguous. We live with it.
There is a problem here though, which is that the quoted strings in
question are part of a list of columns. There's no way to keep that
list as a translatable string, so that approach doesn't work here.
What appears in the translatable string is:
logical replication target relation "%s" is missing replicated columns: %s
Or in the singular case:
logical replication target relation "%s" is missing replicated columns: %s
where the second %s is the list of columns.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Ranier Vilela | 2020-09-11 14:50:37 | Simplified version of read_binary_file (src/backend/utils/adt/genfile.c) |
Previous Message | Tom Lane | 2020-09-11 14:10:32 | Re: Logical Replication - detail message with names of missing columns |