Re: Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros

From: "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com>
To: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros
Date: 2008-10-20 21:49:15
Message-ID: 36e682920810201449w1e1bfca7j41f4aa44ee171cee@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Mon, Oct 20, 2008 at 5:23 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> Hmm, I just noticed this comment in bufpage.h (which was also in Jonah's
> patch) :-(
>
> typedef struct PageHeaderData
> {
> /* XXX LSN is member of *any* block, not only page-organized ones */

Passed regressions and several benchmarks for me.

--
Jonah H. Harris, Senior DBA
myYearbook.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2008-10-20 22:54:04 Re: Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros
Previous Message Alvaro Herrera 2008-10-20 21:23:22 Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2008-10-20 21:51:41 Re: [HACKERS] Debian no longer dumps cores?
Previous Message Alvaro Herrera 2008-10-20 21:23:22 Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros