| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros |
| Date: | 2008-10-20 21:23:22 |
| Message-ID: | 20081020212322.GG4116@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera wrote:
> Log Message:
> -----------
> Properly access a buffer's LSN using existing access macros instead of abusing
> knowledge of page layout.
Hmm, I just noticed this comment in bufpage.h (which was also in Jonah's
patch) :-(
typedef struct PageHeaderData
{
/* XXX LSN is member of *any* block, not only page-organized ones */
...
So I'm now wondering if the above patch is really correct. It'll of
course work, but is it appropriate?
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonah H. Harris | 2008-10-20 21:49:15 | Re: Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros |
| Previous Message | Alvaro Herrera | 2008-10-20 21:11:15 | pgsql: Properly access a buffer's LSN using existing access macros |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonah H. Harris | 2008-10-20 21:49:15 | Re: Re: [COMMITTERS] pgsql: Properly access a buffer's LSN using existing access macros |
| Previous Message | Alvaro Herrera | 2008-10-20 21:11:15 | pgsql: Properly access a buffer's LSN using existing access macros |