Re: [PATCH] Better cleanup in TLS tests for -13beta2

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Felix Lechner <felix(dot)lechner(at)lease-up(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Better cleanup in TLS tests for -13beta2
Date: 2020-06-29 19:51:48
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 29 Jun 2020, at 21:27, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Hmm ... so I guess my reaction to both of these is "what guarantees
>> that we get to the part of the script that does the unlinks?".

> That being said, we do retain temporary files on such failures on purpose in
> our TestLib since 88802e068017bee8cea7a5502a712794e761c7b5 and a few follow-up
> commits since, should these be handled differently? They are admittedly less
> "unknown" as compared to other files as they are copies, but famous last words
> have been spoken about bugs that can never happen.

Oh, good point. Objection withdrawn.

regards, tom lane

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2020-06-29 20:26:23 Re: Parallell hashjoin sometimes ignores temp_tablespaces
Previous Message Daniel Gustafsson 2020-06-29 19:37:54 Re: [PATCH] Better cleanup in TLS tests for -13beta2