From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Felix Lechner <felix(dot)lechner(at)lease-up(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Better cleanup in TLS tests for -13beta2 |
Date: | 2020-06-30 04:13:39 |
Message-ID: | 20200630041339.GA20788@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jun 29, 2020 at 03:51:48PM -0400, Tom Lane wrote:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> That being said, we do retain temporary files on such failures on purpose in
>> our TestLib since 88802e068017bee8cea7a5502a712794e761c7b5 and a few follow-up
>> commits since, should these be handled differently? They are admittedly less
>> "unknown" as compared to other files as they are copies, but famous last words
>> have been spoken about bugs that can never happen.
>
> Oh, good point. Objection withdrawn.
I looked at the patch, and can confirm that client_wrongperms_tmp.key
remains around after running 001_ssltests.pl, and client_tmp.key after
running 002_scram.pl. The way the patch does its cleanup looks fine
to me, so I'll apply and backpatch where necessary, if there are no
objections of course.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-06-30 04:20:00 | Re: Use of "long" in incremental sort code |
Previous Message | Amit Kapila | 2020-06-30 04:13:03 | Re: pgsql: Enable Unix-domain sockets support on Windows |