Re: pgcrypto support for bcrypt $2b$ hashes

From: Daniel Fone <daniel(at)fone(dot)net(dot)nz>
To: Andreas Karlsson <andreas(at)proxel(dot)se>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgcrypto support for bcrypt $2b$ hashes
Date: 2021-10-02 03:48:24
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi Andreas,

> On 1/10/2021, at 12:17 AM, Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
> On 9/28/21 11:58 PM, Daniel Fone wrote:
>>> On 29/09/2021, at 2:33 AM, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>> I don't see why not, the best first patches are those scratching an itch. If
>>> you feel up for it then give it a go, I - and the rest of pgsql-hackers - can
>>> help if you need to bounce ideas.
>> I’m glad you said that. I couldn’t resist trying and have attached a patch. By referencing the respective git logs, I didn’t have too much difficulty identifying the material changes in each codebase. I’ve documented all the postgres-specific changes to upstream in the header comment for each file.
> I took a quick look and on a cursory glance it looks good but I got these compilation warnings.
> crypt-blowfish.c: In function ‘BF_crypt’:
> crypt-blowfish.c:789:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
> 789 | int done;
> | ^~~
> crypt-blowfish.c: In function ‘_crypt_blowfish_rn’:
> crypt-blowfish.c:897:8: warning: variable ‘save_errno’ set but not used [-Wunused-but-set-variable]
> 897 | int save_errno,
> | ^~~~~~~~~~

I don’t get these compiler warnings and I can’t find any settings to use that might generate them. I’m compiling on macOS 11.6 configured with `--enable-cassert --enable-depend --enable-debug CFLAGS=-O0`

I’ve optimistically updated the patch to hopefully address them, but I’d like to know what I need to do to get those warnings.



Attachment Content-Type Size
0001-Merge-upstream-crypt_blowfish-1.3.patch application/octet-stream 25.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-10-02 05:25:44 Re: Memory leak in pg_hmac_final
Previous Message Thomas Munro 2021-10-02 02:41:13 Re: Adding CI to our tree