Re: [PATCH] check for ctags utility in make_ctags

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Nikolay Shaplov <dhyan(at)nataraj(dot)su>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [PATCH] check for ctags utility in make_ctags
Date: 2019-01-03 11:52:36
Message-ID: 364f4cb7-4f1f-516e-d27e-59578b7cf18c@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03/01/2019 12:15, Nikolay Shaplov wrote:
>> +1, let's keep it simple. I would just use "ctags/etags not found"
>> as error message.
>
> Actually I was trying to say "Please install 'ctags' [utility] to run
> make_ctags". But if all of you read it as "Please install 'ctags' [package] to
> run make_ctags", then it is really better to drop the advice.
>
> So I removed it. See the patch.

A few more comments.

I don't know how portable command -v is. Some systems have a /bin/sh
that is pre-POSIX. Same with $(...).

If etags is not installed, the current script prints

xargs: etags: No such file or directory

I don't see the need to do more than that, especially if it makes the
script twice as long.

(Personally, I'd recommend removing make_etags altogether and using GNU
Global for Emacs.)

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikolay Shaplov 2019-01-03 11:53:04 Re: Using vim for developing porstres wiki article
Previous Message Peter Eisentraut 2019-01-03 11:16:25 Re: [HACKERS] Time to change pg_regress diffs to unified by default?