Re: [PATCH] check for ctags utility in make_ctags

From: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Subject: Re: [PATCH] check for ctags utility in make_ctags
Date: 2019-01-03 11:15:11
Message-ID: 2205856.meAnofT0VS@x200m
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

В письме от четверг, 3 января 2019 г. 10:03:53 MSK пользователь Michael
Paquier написал:
> On Wed, Jan 02, 2019 at 11:35:46AM -0500, Tom Lane wrote:
> > In fact, that's demonstrably not so: on my RHEL6 and Fedora boxes,
> > /usr/bin/etags isn't owned by any package, because it's a symlink
> > managed by the "alternatives" system. It points to /usr/bin/etags.emacs
> > which is owned by the emacs-common package. So dropping the advice
> > about how to fix the problem seems like a good plan.
>
> +1, let's keep it simple. I would just use "ctags/etags not found"
> as error message.

Actually I was trying to say "Please install 'ctags' [utility] to run
make_ctags". But if all of you read it as "Please install 'ctags' [package] to
run make_ctags", then it is really better to drop the advice.

So I removed it. See the patch.

Attachment Content-Type Size
check-for-ctags-in-make_ctags_v4.diff text/x-patch 676 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2019-01-03 11:16:25 Re: [HACKERS] Time to change pg_regress diffs to unified by default?
Previous Message Peter Eisentraut 2019-01-03 11:02:47 Re: [HACKERS] Time to change pg_regress diffs to unified by default?