| From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl> |
| Subject: | Re: logical replication apply to run with sync commit off by default |
| Date: | 2017-04-13 21:52:05 |
| Message-ID: | 3626d1be-7faa-7211-4960-ec4241989f7a@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/04/17 06:10, Peter Eisentraut wrote:
> On 3/24/17 10:49, Petr Jelinek wrote:
>> Rebase after table copy patch got committed.
>
> You could please sent another rebase of this, perhaps with some more
> documentation, as discussed downthread.
>
> Also, I wonder why we don't offer the other values of
> synchronous_commit. In any case, we should keep the values consistent.
> So on should be on and local should be local, but not mixing it.
>
Now that I am back from vacation I took look at this again. The reason
why I did only boolean initially is that he other values just didn't
seem all that useful. But you are right it's better to be consistent and
there is no real reason why not to allow all of the possible values.
So how about the attached?
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| Add-option-to-modify-sync-commit-per-subscription-v2.patch | text/plain | 21.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2017-04-13 22:09:23 | Re: Interval for launching the table sync worker |
| Previous Message | Pierre Ducroquet | 2017-04-13 21:32:32 | Small patch for pg_basebackup argument parsing |