| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Олег Самойлов <splarv(at)ya(dot)ru>, pgsql-bugs(at)lists(dot)postgresql(dot)org, Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Subject: | Re: basic_archive lost archive_directory |
| Date: | 2026-02-23 22:22:15 |
| Message-ID: | 3626574.1771885335@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> On Wed, Feb 11, 2026 at 03:14:15PM -0600, Nathan Bossart wrote:
>> On Tue, Feb 10, 2026 at 10:06:25AM -0600, Nathan Bossart wrote:
>>> As I mentioned upthread, IMHO we should simply remove the existence check
>>> from the GUC check hook. basic_archive must already be written to handle
>>> the archive directory disappearing at any moment, so we should be able to
>>> rely on it without the extra stat().
> Any thoughts? I'll wait another week or so, but then will proceed with
> committing/back-patching this.
Agreed --- this seems like a pretty inappropriate check to be making
in a check_hook.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-02-23 23:20:11 | Re: BUG #19393: pg_upgrade fails with duplicate key violation when CHECK constraint named *_not_null exists |
| Previous Message | Nathan Bossart | 2026-02-23 21:38:47 | Re: basic_archive lost archive_directory |