Re: [HACKERS] Current sources?

Yikes!

I see my little patch as stirred things up a bit. Bruce, your addition does meet the needs of the
intent of my patch. I tried it here with positive results. I hope you will keep the whole patch.

For what it is worth, I did run the regression test. But I did not get any failures that appeared to
be the a result of the patch. There were, however, many failures before and after my patch. Most
were due to AIX system messages but there many, though, I could not explain. I will gladly report them
if any one is interested.

I have to admit that I was nervous about submitting my first patch into an area code as important this
one. I would have liked to start off with a new data type or something. Unfortunately, I was
getting beat up by ODBC/MS Access users which routinely generate queries which the backend could not
handle.

Thanks for your tolerance.

Bruce Momjian wrote:

> > I wouldn't say that the patch should be removed from the CVS. I just
> > need my *private* working snapshot to make sure my patches would not
> > break anything before submitting.
> >
> > I wish I could solve the problem by myself, but spending a few hours
> > for debugging last Sunday, I have not find fixes for that yet. Sorry.
>
> OK, here is a fix I have just applied to the tree. It appears to meet
> the intent of the original patch. David H. will have to comment on its
> accuracy.
>
> ---------------------------------------------------------------------------
>
> Index: backend/executor/execMain.c
> ===================================================================
> RCS file: /usr/local/cvsroot/pgsql/src/backend/executor/execMain.c,v
> retrieving revision 1.46
> diff -c -r1.46 execMain.c
> *** execMain.c 1998/05/21 03:53:50 1.46
> --- execMain.c 1998/05/26 03:33:22
> ***************
> *** 530,536 ****
> JunkFilter *j = (JunkFilter *) ExecInitJunkFilter(targetList);
> estate->es_junkFilter = j;
>
> ! tupType = j->jf_cleanTupType; /* Added by daveh(at)insightdist(dot)com 5/20/98 */
> }
> else
> estate->es_junkFilter = NULL;
> --- 530,537 ----
> JunkFilter *j = (JunkFilter *) ExecInitJunkFilter(targetList);
> estate->es_junkFilter = j;
>
> ! if (operation == CMD_SELECT)
> ! tupType = j->jf_cleanTupType;
> }
> else
> estate->es_junkFilter = NULL;
>