Re: BUG #17220: ALTER INDEX ALTER COLUMN SET (..) with an optionless opclass makes index and table unusable

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, "postgresql(at)zr40(dot)nl" <postgresql(at)zr40(dot)nl>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: BUG #17220: ALTER INDEX ALTER COLUMN SET (..) with an optionless opclass makes index and table unusable
Date: 2021-10-18 21:43:58
Message-ID: 355E7866-D1F3-4533-BE6C-17DBDA6A2ADD@amazon.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 10/18/21, 12:47 AM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> I have reviewed the last patch posted upthread, and while testing
> partitioned indexes I have noticed that we don't need to do a custom
> check as part of ATExecSetOptions(), because we have already that in
> ATSimplePermissions() with details on the relkind failing. This makes
> the patch simpler, with a better error message generated. I have
> added a case for partitioned indexes while on it.

Ah, yes, that is much better.

> Attached is the patch I am finishing with, that should go down to
> v13 (this is going to conflict on REL_13_STABLE, for sure).

+DROP INDEX btree_tall_tbl_idx2;
+ERROR: index "btree_tall_tbl_idx2" does not exist

I think this is supposed to be "btree_tall_idx2". Otherwise, the
patch looks reasonable to me.

Nathan

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Bossart, Nathan 2021-10-18 23:46:56 Re: Inconsistent behavior of pg_dump/pg_restore on DEFAULT PRIVILEGES
Previous Message Peter Geoghegan 2021-10-18 18:27:22 Re: BUG #17229: Segmentation Fault after upgrading to version 13

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-10-18 22:14:49 Re: Partition Check not updated when insert into a partition
Previous Message Alvaro Herrera 2021-10-18 20:36:34 Re: [PATCH] Proposal for HIDDEN/INVISIBLE column