Re: [PATCH] Proposal for HIDDEN/INVISIBLE column

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Gilles Darold <gilles(at)migops(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Proposal for HIDDEN/INVISIBLE column
Date: 2021-10-18 20:36:34
Message-ID: 202110182036.pkngfqfxb57p@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Oct-18, Gilles Darold wrote:

> Le 18/10/2021 à 18:54, Alvaro Herrera a écrit :
> > I suggest to look for output test files that are being massively
> > modified by this patch. I think those are likely unintended:
> >
> >> diff --git a/src/test/regress/expected/collate.icu.utf8.out b/src/test/regress/expected/collate.icu.utf8.out
> >> diff --git a/src/test/regress/expected/collate.linux.utf8.out b/src/test/regress/expected/collate.linux.utf8.out
> >> diff --git a/src/test/regress/expected/compression.out b/src/test/regress/expected/compression.out
> >> diff --git a/src/test/regress/expected/xml.out b/src/test/regress/expected/xml.out
> >> diff --git a/src/test/regress/expected/xmlmap.out b/src/test/regress/expected/xmlmap.out
>
> My bad, thanks for the report Alvaro. New patch version v3 should fix that.

Hmm, the attachment was 500kB before, about 30% of that was the
collate.*.out files, and it is 2.2 MB now. Something is still not
right.

--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
"Porque francamente, si para saber manejarse a uno mismo hubiera que
rendir examen... ¿Quién es el machito que tendría carnet?" (Mafalda)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bossart, Nathan 2021-10-18 21:43:58 Re: BUG #17220: ALTER INDEX ALTER COLUMN SET (..) with an optionless opclass makes index and table unusable
Previous Message Gilles Darold 2021-10-18 20:15:23 Re: [PATCH] Proposal for HIDDEN/INVISIBLE column