| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: race condition in sync rep |
| Date: | 2011-03-26 16:04:56 |
| Message-ID: | 3555.1301155496@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> I've added code for you.
> Your skepticism seems out of place. I actually hit this problem in testing. We could debate how realistic my test setup was, but why? It is not our policy - and bad practice in general - to ship code with race conditions. The code you added is not "for me"; it's "to fix a race condition".
In particular, in view of today's fix, shouldn't this commit be reverted?
I thought at the time that that was nothing more than documenting a
known bug, and now it is documenting a dead bug.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2011-03-26 16:12:24 | Re: Lock problem with autovacuum truncating heap |
| Previous Message | Tom Lane | 2011-03-26 15:46:09 | Re: 9.1 Beta |