Re: Remove inconsistent quotes from date_part error

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Nikhil Benesch <nikhil(dot)benesch(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove inconsistent quotes from date_part error
Date: 2022-01-03 15:20:35
Message-ID: 3546614.1641223235@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Nikhil Benesch <nikhil(dot)benesch(at)gmail(dot)com> writes:
> - errmsg("\"time with time zone\" units \"%s\" not recognized",
> + errmsg("time with time zone units \"%s\" not recognized",
> [ etc ]

BTW, if you want to get rid of the quotes, I think that something
else has to be done to set off the type name from the rest. In
this instance someone might think that we're complaining about a
"time zone unit", whatever that is. I suggest swapping it around to

units \"%s\" not recognized for type %s

Also, personally, I'd write unit not units, but that's
more debatable.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikhil Benesch 2022-01-03 15:26:08 Re: Remove inconsistent quotes from date_part error
Previous Message Nikhil Benesch 2022-01-03 15:12:59 Re: Remove inconsistent quotes from date_part error