Re: test/isolation/expected/stats_1.out broken for me

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: chap(at)anastigmatix(dot)net, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: test/isolation/expected/stats_1.out broken for me
Date: 2022-04-07 22:31:35
Message-ID: 3528951.1649370695@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-04-07 09:57:09 -0700, Andres Freund wrote:
>> Yea :(. I tested debug_discard_caches, but not -DRELCACHE_FORCE_RELEASE
>> -DCATCACHE_FORCE_RELEASE.
>>
>> Not quite sure what to do about it - it's intentionally trying to test the
>> case of no invalidations being processed, as that's an annoying edge case with
>> functions. Perhaps wrapping the function call of the "already dropped"
>> function in another function that catches the error would do the trick? It'd
>> be more easily silently broken, but still be better than not having the test.

> Anybody got a better idea?

Maybe if the wrapper function checks for exactly the two expected
behaviors, it'd be robust enough?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-04-07 22:37:11 Re: pg14 psql broke \d datname.nspname.relname
Previous Message Tom Lane 2022-04-07 22:29:53 Re: trigger example for plsample