| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Rebuild CHECK constraints after generated column SET EXPRESSION |
| Date: | 2026-07-08 18:15:54 |
| Message-ID: | 34e93378-06db-4404-a8e7-3a944912a823@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02.06.26 02:41, jian he wrote:
> On Fri, May 29, 2026 at 6:58 AM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>>
>> Looks good, I have one nitpick question:
>>
>> + if (isnull)
>> + elog(WARNING, "null conbin for relation \"%s\"",
>> + RelationGetRelationName(rel));
>>
>> Shouldn't this be an error instead? Most existing checks treat it as
>> an error, and that seems better to me as this shouldn't happen
>> normally?
>>
> OK.
>
> I changed it to:
>> + if (isnull)
>> + elog(ERROR, "null conbin for relation \"%s\"",
>> + RelationGetRelationName(rel));
>
> I also slightly rephrased the commit message.
Committed with some code beautification editorialization.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-07-08 18:20:43 | Re: Fix SET EXPRESSION for virtual columns with whole-row dependencies |
| Previous Message | Jelte Fennema-Nio | 2026-07-08 18:13:56 | Re: Can we get rid of TerminateThread() in pg_dump? |