Re: BUG #5339: Version of Perl detected incorrectly

On Mon, Feb 22, 2010 at 10:57, Jonathan <jonathan(at)leto(dot)net> wrote:
>
> The following bug has been logged online:
>
> Bug reference:      5339
> Logged by:          Jonathan "Duke" Leto
> Email address:      jonathan(at)leto(dot)net
> PostgreSQL version: master 0f50d482
> Operating system:   CentOS 5.4 (Linux kernel 2.6.18)
> Description:        Version of Perl detected incorrectly
> Details:
>
> $  perl -v
>
> This is perl 5, version 11, subversion 4 (v5.11.4-114-ga4cc961*) built for
> x86_64-linux
...
> checking for perl... /home/leto/bin/perl
> configure: using perl
> configure: WARNING:
> *** The installed version of Perl, /home/leto/bin/perl, is too old to use
> with PostgreSQL.
> *** Perl version 5.8 or later is required, but this is .

Yeah find the below which attempts to clean this up a bit. Instead of
parsing perl -v output, we just "use" the min required version and
rely on perl error out for us. Its also more or less what we do at
runtime in plc_perl_boot.pl now.

Thoughts?

*** a/configure
--- b/configure
***************
*** 6867,6884 **** fi
fi

if test "$PERL"; then
! pgac_perl_version=`$PERL -v 2>/dev/null | sed -n 's/This is perl,
v[a-z ]*//p' | sed 's/ .*//'`
! { $as_echo "$as_me:$LINENO: using perl $pgac_perl_version" >&5
! $as_echo "$as_me: using perl $pgac_perl_version" >&6;}
! if echo "$pgac_perl_version" | sed 's/[.a-z_]/ /g' | \
! $AWK '{ if ($1 = 5 && $2 >= 8) exit 1; else exit 0;}'
! then
{ $as_echo "$as_me:$LINENO: WARNING:
*** The installed version of Perl, $PERL, is too old to use with PostgreSQL.
! *** Perl version 5.8 or later is required, but this is
$pgac_perl_version." >&5
$as_echo "$as_me: WARNING:
*** The installed version of Perl, $PERL, is too old to use with PostgreSQL.
! *** Perl version 5.8 or later is required, but this is
$pgac_perl_version." >&2;}
PERL=""
fi
fi
--- 6867,6880 ----
fi

if test "$PERL"; then
! perl_version_error=`$PERL -e 'use 5.00801;' 2>&1`
! if test -n "$perl_version_error"; then
{ $as_echo "$as_me:$LINENO: WARNING:
*** The installed version of Perl, $PERL, is too old to use with PostgreSQL.
! *** $perl_version_error." >&5
$as_echo "$as_me: WARNING:
*** The installed version of Perl, $PERL, is too old to use with PostgreSQL.
! *** $perl_version_error." >&2;}
PERL=""
fi
fi