Re: Miscellaneous changes to plperl [PATCH]

From: Alex Hunsaker <badalex(at)gmail(dot)com>
To: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
Cc: Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Miscellaneous changes to plperl [PATCH]
Date: 2010-01-23 19:53:28
Message-ID: 34d269d41001231153k2140af24k17393bdae65780e@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 23, 2010 at 12:42, David E. Wheeler <david(at)kineticode(dot)com> wrote:
> On Jan 23, 2010, at 11:20 AM, Alex Hunsaker wrote:
>
>> Well no, i suppose we could fix that via:
>> $name =~ s/[:|']/_/g;
>>
>> Im betting that was the intent.
>
> Doubtful. In Perl, the package separator is either `::` or `'` (for hysterical reasons). So the original code was replacing any package separator with a single underscore. Your regex would change This::Module to This__Module, which I'm certain was not the intent.

Haha, yep your right. I could have sworn I tested it with a function
name with a ' and it broke. But your obviously right :)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-01-23 19:56:54 Re: commit fests
Previous Message Andrew Dunstan 2010-01-23 19:49:30 Re: 8.5 vs. 9.0, Postgres vs. PostgreSQL