Re: Error messages/logging (Was: Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/parser gram.y parse_oper.c')

From: "Vadim B(dot) Mikheev" <vadim(at)sable(dot)krasnoyarsk(dot)su>
To: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
Cc: matti(at)algonet(dot)se, hackers(at)postgreSQL(dot)org
Subject: Re: Error messages/logging (Was: Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/parser gram.y parse_oper.c')
Date: 1998-01-05 03:35:10
Message-ID: 34B054EE.A7333EF2@sable.krasnoyarsk.su
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian wrote:
>
> >
> > Mattias Kregert wrote:
> > >
> > > Bruce Momjian wrote:
> > > >
> > >
> > > > I just think the WARN word coming up on users terminals is odd. I can
> > > > make the change in all the source files easily if we decide what the new
> > > > error word should be. Error? Failure?
> > > >
> > >
> > > Yes, that's one of the things I don't understand with PostgreSQL.
> > > ERROR would be much better.
> >
> > How about ABORT ?
>
> Sounds maybe a little too serious. We currently use WARN a lot to
> indicate errors in the supplied SQL statement. Perhaps we need to make
> the parser elog's ERROR, and the non-parser WARN's ABORT? Is that good?
> When can I make the change? I don't want to mess up people's current work.

ABORT means that transaction is ABORTed.
Will ERROR mean something else ?
Why should we use two different flag-words for the same thing ?
Note, that I don't object against using ERROR, but against using two words.

Vadim

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vadim B. Mikheev 1998-01-05 04:14:49 Re: [HACKERS] include/config.h FOLLOWUP
Previous Message Bruce Momjian 1998-01-05 03:25:03 Re: Error messages/logging (Was: Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/parser gram.y parse_oper.c')