Re: Error messages/logging (Was: Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/parser gram.y parse_oper.c')

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: vadim(at)sable(dot)krasnoyarsk(dot)su (Vadim B(dot) Mikheev)
Cc: matti(at)algonet(dot)se, hackers(at)postgreSQL(dot)org
Subject: Re: Error messages/logging (Was: Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/parser gram.y parse_oper.c')
Date: 1998-01-05 03:25:03
Message-ID: 199801050325.WAA18155@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> ABORT means that transaction is ABORTed.
> Will ERROR mean something else ?
> Why should we use two different flag-words for the same thing ?
> Note, that I don't object against using ERROR, but against using two words.

I wanted two words to distinguish between user errors like a mis-spelled
field name, and internal errors like btree failure messages.

Make sense?

I made all the error messages coming from the parser as ERROR, and
non-parser messages as ABORT. I think I will need to fine-tune the
messages because I am sure I missed some messages that should be ERROR
but are ABORT. For example, utils/adt messages about improper data
formats, is that an ERROR or an ABORT?

--
Bruce Momjian
maillist(at)candle(dot)pha(dot)pa(dot)us

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vadim B. Mikheev 1998-01-05 03:35:10 Re: Error messages/logging (Was: Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/parser gram.y parse_oper.c')
Previous Message Bruce Momjian 1998-01-05 02:22:50 Re: Error messages/logging (Was: Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/parser gram.y parse_oper.c')