Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> On 06.12.22 09:41, Antonin Houska wrote:
> > Attached are my proposals for improvements. One is to avoid memory leak, the
> > other tries to improve readability a little bit.
>
> I added the readability improvement to my v2 patch. The pfree() calls aren't
> necessary AFAICT.
I see that memory contexts exist and that the amount of memory freed is not
huge, but my style is to free the memory explicitly if it's allocated in a
loop.
v2 looks good to me.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com