From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
---|---|
To: | Antonin Houska <ah(at)cybertec(dot)at> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: refactor ExecGrant_*() functions |
Date: | 2022-12-13 06:54:07 |
Message-ID: | 21375e35-07a2-a60e-c36e-286a46c9fc47@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 12.12.22 10:44, Antonin Houska wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
>> On 06.12.22 09:41, Antonin Houska wrote:
>>> Attached are my proposals for improvements. One is to avoid memory leak, the
>>> other tries to improve readability a little bit.
>>
>> I added the readability improvement to my v2 patch. The pfree() calls aren't
>> necessary AFAICT.
It's something to consider, but since this is a refactoring patch and
the old code didn't do it either, I think it's out of scope.
> I see that memory contexts exist and that the amount of memory freed is not
> huge, but my style is to free the memory explicitly if it's allocated in a
> loop.
>
> v2 looks good to me.
Committed, thanks.
From | Date | Subject | |
---|---|---|---|
Next Message | Julien Rouhaud | 2022-12-13 07:29:03 | Re: Add sub-transaction overflow status in pg_stat_activity |
Previous Message | Peter Smith | 2022-12-13 05:45:00 | Re: Force streaming every change in logical decoding |