Re: query logging of prepared statements

From: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: query logging of prepared statements
Date: 2019-03-05 10:30:18
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-general pgsql-hackers

On 04.03.2019 21:31, Justin Pryzby wrote:
> It wasn't intentional. Find attached v3 patch which handles that case,
> by removing the 2nd call to errdetail_execute() ; since it's otherwise unused,
> so remove that function entirely.

Thank you.

> Thanks for reviewing. I'm also interested in discussion about whether this
> change is undesirable for someone else for some reason ? For me, the existing
> output seems duplicative and "denormalized". :)

I perfectly understand your use case. I agree, it is duplicated. But I
think some people may want to see it at every EXECUTE, if they don't
want to grep for the prepared statement body which was logged earlier.

I think it would be good to give possibility to configure this behavior.
At first version of your patch you relied on log_error_verbosity GUC.
I'm not sure that this variables is suitable for configuring visibility
of prepared statement body in logs, because it sets more general
behavior. Maybe it would be better to introduce some new GUC variable if
the community don't mind.

Arthur Zakirov
Postgres Professional:
Russian Postgres Company

In response to


Browse pgsql-general by date

  From Date Subject
Next Message Mohit Kumar Sahni 2019-03-05 12:19:35 Connection Drop from PostgreSQL Database Server
Previous Message Sergei Kornilov 2019-03-05 07:42:47 Re: Question about pg_upgrade from 9.2 to X.X

Browse pgsql-hackers by date

  From Date Subject
Next Message Raúl Marín Rodríguez 2019-03-05 11:00:33 Re: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
Previous Message Amit Langote 2019-03-05 10:25:13 Re: speeding up planning with partitions