| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "'alvherre(at)alvh(dot)no-ip(dot)org'" <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | "iwata(dot)aya(at)fujitsu(dot)com" <iwata(dot)aya(at)fujitsu(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "'Kyotaro Horiguchi'" <horikyota(dot)ntt(at)gmail(dot)com>, "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: libpq debug log |
| Date: | 2021-04-01 17:46:37 |
| Message-ID: | 3455705.1617299197@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"'alvherre(at)alvh(dot)no-ip(dot)org'" <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> On 2021-Apr-01, Tom Lane wrote:
>> BTW, what in the world is this supposed to accomplish?
>> - (long long) rows_to_send);
>> + (1L << 62) + (long long) rows_to_send);
> It makes the text representation wider, which means some buffer fills up
> faster and the program switches from sending to receiving.
Hm. If the actual field value isn't relevant, why bother including
rows_to_send in it? A constant string would be simpler and much
less confusing as to its purpose.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2021-04-01 17:48:34 | Re: Data type correction in pgstat_report_replslot function parameters |
| Previous Message | Robert Haas | 2021-04-01 17:41:50 | Re: pg_amcheck contrib application |