| From: | "'alvherre(at)alvh(dot)no-ip(dot)org'" <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "iwata(dot)aya(at)fujitsu(dot)com" <iwata(dot)aya(at)fujitsu(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, 'Kyotaro Horiguchi' <horikyota(dot)ntt(at)gmail(dot)com>, "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: libpq debug log |
| Date: | 2021-04-01 19:05:36 |
| Message-ID: | 20210401190536.GA29620@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Apr-01, Tom Lane wrote:
> "'alvherre(at)alvh(dot)no-ip(dot)org'" <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > On 2021-Apr-01, Tom Lane wrote:
> >> BTW, what in the world is this supposed to accomplish?
> >> - (long long) rows_to_send);
> >> + (1L << 62) + (long long) rows_to_send);
>
> > It makes the text representation wider, which means some buffer fills up
> > faster and the program switches from sending to receiving.
>
> Hm. If the actual field value isn't relevant, why bother including
> rows_to_send in it? A constant string would be simpler and much
> less confusing as to its purpose.
Hah, yeah, we could as well do that I guess :-)
--
Álvaro Herrera Valdivia, Chile
"I think my standards have lowered enough that now I think 'good design'
is when the page doesn't irritate the living f*ck out of me." (JWZ)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 'alvherre@alvh.no-ip.org' | 2021-04-01 19:07:19 | Re: libpq debug log |
| Previous Message | Peter Eisentraut | 2021-04-01 18:49:45 | Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost when extracting epoch |