From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
Cc: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, myon(at)debian(dot)org |
Subject: | Re: ci: Skip minfree file in the cores_backtrace.sh |
Date: | 2025-10-17 12:31:40 |
Message-ID: | 343B7066-01E3-4850-B2C4-90CD84004526@yesql.se |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 17 Oct 2025, at 14:25, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2025-Oct-17, Nazir Bilal Yavuz wrote:
>
>> first=1
>> -for corefile in $(find "$directory" -type f) ; do
>> +# minfree is not a core file but may exists in the crash directory, skip it
>> +for corefile in $(find "$directory" -type f -not -name "minfree") ; do
>> if [ "$first" -eq 1 ]; then
>> first=0
>> else
>
> This looks quite random. Why not do "find ... -name '*core*'" instead?
> I mean, if we have minfree there today, we could have maxbusy tomorrow
> or whatever.
I think we should be able to count of the core directory on controlled CI
instances not being cluttered with random files - if it is we probably want a
test failure logged so we can look at it - but minfree is a special file for
core dump handling on some platforms so skipping that make sense I think.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Nazir Bilal Yavuz | 2025-10-17 12:38:03 | Re: ci: Skip minfree file in the cores_backtrace.sh |
Previous Message | Álvaro Herrera | 2025-10-17 12:26:09 | Re: Inconsistent LSN format in pg_waldump output |