Re: ci: Skip minfree file in the cores_backtrace.sh

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, myon(at)debian(dot)org
Subject: Re: ci: Skip minfree file in the cores_backtrace.sh
Date: 2025-10-17 12:25:19
Message-ID: 202510171220.2i45gsy3w7af@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-Oct-17, Nazir Bilal Yavuz wrote:

> first=1
> -for corefile in $(find "$directory" -type f) ; do
> +# minfree is not a core file but may exists in the crash directory, skip it
> +for corefile in $(find "$directory" -type f -not -name "minfree") ; do
> if [ "$first" -eq 1 ]; then
> first=0
> else

This looks quite random. Why not do "find ... -name '*core*'" instead?
I mean, if we have minfree there today, we could have maxbusy tomorrow
or whatever.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"We’ve narrowed the problem down to the customer’s pants being in a situation
of vigorous combustion" (Robert Haas, Postgres expert extraordinaire)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-10-17 12:26:09 Re: Inconsistent LSN format in pg_waldump output
Previous Message Álvaro Herrera 2025-10-17 12:13:08 Re: misleading error message in ProcessUtilitySlow T_CreateStatsStmt