| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Provide overflow safe integer math inline functions. |
| Date: | 2017-12-17 16:03:49 |
| Message-ID: | 3357.1513526629@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> ... Please note that if you added
> a volatile cast to "result" as well, then compilation was able to
> complete and regression tests passed...
Yeah, that squares with my analysis: the problem with the existing test
is that the compiler is throwing away the function call because its
output is unused.
If I haven't seen something from Andres shortly, I'll push a fix.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-12-17 16:52:26 | pgsql: Try harder to detect unavailability of __builtin_mul_overflow(in |
| Previous Message | Michael Paquier | 2017-12-17 07:00:31 | Re: pgsql: Provide overflow safe integer math inline functions. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-12-17 20:29:08 | Re: Top-N sorts verses parallelism |
| Previous Message | Alvaro Herrera | 2017-12-17 15:50:38 | Re: [HACKERS] Proposal: Local indexes for partitioned table |