| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Provide overflow safe integer math inline functions. |
| Date: | 2017-12-18 16:40:06 |
| Message-ID: | 20171218164006.hmyijjs2dgqfkhuh@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2017-12-17 11:03:49 -0500, Tom Lane wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> > ... Please note that if you added
> > a volatile cast to "result" as well, then compilation was able to
> > complete and regression tests passed...
>
> Yeah, that squares with my analysis: the problem with the existing test
> is that the compiler is throwing away the function call because its
> output is unused.
>
> If I haven't seen something from Andres shortly, I'll push a fix.
Thanks! Was off for most of yesterday...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-12-18 17:34:07 | pgsql: Fix crashes on plans with multiple Gather (Merge) nodes. |
| Previous Message | Magnus Hagander | 2017-12-18 10:25:26 | pgsql: Fix typo on comment |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-12-18 16:46:53 | Re: Protect syscache from bloating with negative cache entries |
| Previous Message | Robert Haas | 2017-12-18 16:12:34 | Re: [HACKERS] Custom compression methods |