Re: segmentation fault when cassert enabled

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
Cc: Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: segmentation fault when cassert enabled
Date: 2019-12-16 12:27:43
Message-ID: 32a64f45-6c01-d2bf-d90a-49ff4bfedcfb@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-12-16 11:11, Amit Kapila wrote:
> I agree that this is a timing issue. I also don't see a way to write
> a reproducible test for this. However, I could reproduce it via
> debugger consistently by following the below steps. I have updated a
> few comments and commit messages in the attached patch.
>
> Peter E., Petr J or anyone else, do you have comments or objections on
> this patch? If none, then I am planning to commit (and backpatch)
> this patch in a few days time.

The patch seems fine to me. Writing a test seems hard. Let's skip it.

The commit message has a duplicate "building"/"built" in the first sentence.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Juan José Santamaría Flecha 2019-12-16 12:40:40 Re: Collation versions on Windows (help wanted, apply within)
Previous Message Peter Eisentraut 2019-12-16 12:20:59 Re: Collation versions on Windows (help wanted, apply within)