src/tools/pginclude considered harmful (was Re: [PATCHES] toast index entries again)

Kris Jurka <books(at)ejurka(dot)com> writes:
> The inclusion of access/tuptoaster.h in access/common/indextuple.c brought
> in the define of TOAST_INDEX_HACK which compresses large index entries.
> When this was removed the entries were no longer compressed which caused
> btree_gist to fail.

This is seriously scary, as it seems quite possible that there are other
similar cases in which we have simply silently lost functionality or
performance, and none of the regression tests will expose it.

In combination with the amount of time wasted over the past two days,
it is now perfectly clear that the existing pginclude tools are not
NEARLY good enough to detect what they are breaking. I would like to
propose that we revert all the include-related changes of the past two
days, and that src/tools/pginclude be removed from the CVS tree, until
such time as it is rewritten to be much smarter about what it is doing.

regards, tom lane