Re: src/tools/pginclude considered harmful (was Re:

On Fri, 2006-07-14 at 14:20 -0400, Tom Lane wrote:
> I would like to propose that we revert all the include-related changes
> of the past two days, and that src/tools/pginclude be removed from the
> CVS tree, until such time as it is rewritten to be much smarter about
> what it is doing.

Rather than reverting the changes in CVS and then redoing them
correctly, perhaps we could make the necessary improvements to the
tools, apply the improved tools to the pre-cleaned-up version of the
tree, get a diff against HEAD, and then apply any fixes the improved
tools have made as a patch. That would avoid cluttering CVS with two
redundant changes to almost every single source file in the tree.

In any case, I agree that the cleanup was not very well done. Widespread
cleanup of this sort should be done with a lot more care. One useful
improvement would be to make the changes on a local repository first,
and then post the suggested changes as a patch. Making the entire set of
required changes as a single CVS commit would also be good: it makes it
easier for folks to back out the patch locally if it causes problems, as
well as making the CVS history more comprehensible.

-Neil