Re: New windows compiler warning from 585bca39

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, magnus(at)hagander(dot)net
Subject: Re: New windows compiler warning from 585bca39
Date: 2014-04-17 20:14:55
Message-ID: 32359.1397765695@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> I've attached a tiny patch that fixes a new compiler warning on the windows
> build...

Applied, thanks.

> Perhaps the #ifndef could be placed in a nicer spot in the patch, but the
> attached should at least describe where the problem lies...

Yeah, I thought it better to make a separate declaration to wrap in
#ifndef. pgindent is probably going to insist on adding some vertical
whitespace around the #if, and that'll look horrid if it's just in the
middle of a list of variables.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Steve Singer 2014-04-17 20:23:54 assertion in 9.4 with wal_level=logical
Previous Message Stephen Frost 2014-04-17 19:47:39 Re: Clock sweep not caching enough B-Tree leaf pages?